Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typo #1686

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix Typo #1686

merged 2 commits into from
Oct 2, 2024

Conversation

MarcelKoch
Copy link
Member

This PR fixes the typo clonable -> cloneable. This has no interface changes.

@MarcelKoch MarcelKoch added the 1:ST:no-changelog-entry Skip the wiki check for changelog update label Oct 2, 2024
@MarcelKoch MarcelKoch requested review from a team October 2, 2024 13:49
@MarcelKoch MarcelKoch self-assigned this Oct 2, 2024
@MarcelKoch MarcelKoch removed the request for review from a team October 2, 2024 13:49
@ginkgo-bot ginkgo-bot added the mod:core This is related to the core module. label Oct 2, 2024
yhmtsai
yhmtsai approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. there are still some missing fix typo mentioned by typo workflow.

pratikvn
pratikvn reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places that were missed (See files diff). But otherwise LGTM!

include/ginkgo/core/base/utils_helper.hpp Outdated Show resolved Hide resolved
include/ginkgo/core/base/utils_helper.hpp Outdated Show resolved Hide resolved
@MarcelKoch MarcelKoch merged commit e518aee into develop Oct 2, 2024
11 of 14 checks passed
@MarcelKoch MarcelKoch deleted the fix-typo-cloneable branch October 2, 2024 14:00
@ginkgo-bot
Copy link
Member

Error: PR already merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhmtsai yhmtsai yhmtsai approved these changes

@pratikvn pratikvn pratikvn approved these changes

Assignees

@MarcelKoch MarcelKoch

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update mod:core This is related to the core module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcelKoch @ginkgo-bot @pratikvn @yhmtsai